Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UT] k8s/utils/util.go ut enhancement #23680

Merged
merged 1 commit into from
Feb 22, 2023
Merged

[UT] k8s/utils/util.go ut enhancement #23680

merged 1 commit into from
Feb 22, 2023

Conversation

my-git9
Copy link
Contributor

@my-git9 my-git9 commented Feb 12, 2023 •
edited by squeed

k8s/utils/util.go ut enhancement

@my-git9 my-git9 requested a review from a team as a code owner February 12, 2023 05:55
@my-git9 my-git9 requested a review from squeed February 12, 2023 05:55
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 12, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 12, 2023
squeed
squeed requested changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@squeed squeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: there is a small lint error.

pkg/k8s/utils/utils_test.go Show resolved Hide resolved
@my-git9 my-git9 requested a review from squeed February 13, 2023 12:27
squeed
squeed requested changes Feb 14, 2023
View reviewed changes
pkg/k8s/utils/utils_test.go Show resolved Hide resolved
@my-git9
[UT] /k8s/utils/util.go ut enhancement
d4cb8e8 
Signed-off-by: xin.li <xin.li@daocloud.io>
@my-git9 my-git9 requested a review from squeed February 14, 2023 14:12
@squeed squeed added the release-note/misc This PR makes changes that have no direct user impact. label Feb 22, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 22, 2023
@squeed squeed added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 22, 2023
@squeed
Copy link
Contributor

squeed commented Feb 22, 2023

Marking as ready-to-merge; this is a go test function, it doesn't need a CI run.

@pchaigno pchaigno merged commit 199bb41 into cilium:master Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@my-git9 @squeed @pchaigno