Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Governance add CNCF Resources and Link CoC #23689

Merged
merged 1 commit into from Feb 22, 2023
Merged

Docs: Governance add CNCF Resources and Link CoC #23689

merged 1 commit into from Feb 22, 2023

Conversation

xmulligan
Copy link
Member

Signed-off-by: Bill Mulligan billmulligan516@gmail.com

add CNCF Resources and Link CoC to Governance docs

@xmulligan xmulligan requested review from a team as code owners February 12, 2023 16:49
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 12, 2023
@xmulligan xmulligan added area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. and removed area/misc Impacts miscellaneous areas of the code not otherwise owned by another area. labels Feb 12, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 12, 2023
@qmonnet
Copy link
Member

qmonnet commented Feb 13, 2023

Checkpatch is strict on the case.

image

(Note: You can drop the Co-authored-by: completely for a suggestion that small.)

@xmulligan
Docs: Governance add CNCF Resources and Link CoC
ca6a0c5 
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
qmonnet
qmonnet approved these changes Feb 13, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xmulligan xmulligan added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 22, 2023
@pchaigno pchaigno merged commit 12a4387 into master Feb 22, 2023
@pchaigno pchaigno deleted the xmulligan-patch-1 branch February 22, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@aditighag aditighag Awaiting requested review from aditighag aditighag was automatically assigned from cilium/contributing

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xmulligan @qmonnet @pchaigno