operator: cleanup CRD registration #23701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleanup CRD registration at operator startup by removing boilerplate functions. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
the
release-note/misc
|
/test |
squeed
reviewed
Feb 13, 2023
| crd *apiextensionsv1.CustomResourceDefinition, | ||
| poller poller, | ||
| ) error { | ||
| scopedLog := log.WithField("name", crdName) | ||
| scopedLog := log.WithField("name", crd.Name) | ||
|
|
||
| if !k8sversion.Capabilities().APIExtensionsV1CRD { |
There was a problem hiding this comment.
I'm pretty sure that this check can go away; can you confirm and, if reasonable, remove it too?
There was a problem hiding this comment.
good point.
should be possible to remove since the oldest k8s release supported by stable cilium is k8s 1.16 (https://docs.cilium.io/en/stable/concepts/kubernetes/compatibility/#kubernetes-compatibility) and since k8s 1.16 CRD v1 is supported (https://kubernetes.io/docs/reference/using-api/deprecation-guide/#customresourcedefinition-v122).
going to remove this check and its logic
squeed
approved these changes
Feb 13, 2023
Support for CRD v1beta1 has been removed, since this is no longer necessary in all supported k8s versions. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
|
removed v1beta1 CRD support |
|
lgtm! |
squeed
added
the
ready-to-merge
|
/test |
|
I see testing is not done yet, removing |
nbusseneau
removed
the
ready-to-merge
|
/ci-verifier |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanup CRD registration at operator startup by removing boilerplate functions and CRD v1beta1 support.