New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e-tests: git-ignore directory old-charts #23705
e2e-tests: git-ignore directory old-charts #23705
Conversation
The e2e-test updates.go downloads old cilium releases to the directory old-charts. This directory should be ignored by GIT to prevent an unintentional commit after executing the e2e-tests locally. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, can you clarify how you found this out? I'm not sure I've ever encountered it, so curious on how I would reproduce 🤔
@nbusseneau after executing the updates e2e-test locally against a kind cluster i encounter this "leftover" -> e.g. |
/test |
/ci-verifier |
/ci-l4lb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then it's an easy approve :)
The e2e-test updates.go downloads old cilium releases to the directory old-charts. This directory should be ignored by GIT to prevent an unintentional commit after executing the e2e-tests locally.