bpf: dedicated functions for per-packet lb xlate

[ldelossa]

House-keeping task which introduces dedicated inline functions for per-packet-lb service translation on pod egress.

Cleans up the __handle_ip* methods in bpf_lxc.c so they can be dedicated to expressing the packet flow.

Signed-off-by: Louis DeLosSantos louis.delos@isovalent.com

introduces dedicated inline functions for per-packet-lb service translation on pod egress

[ldelossa]

Hold in draft until: #22936 merged, then rebase.

[ldelossa]

/test

[ldelossa]

/test

[ldelossa]

/test-1.25-4.19

[ldelossa]

Some combination of macro defs are causing a preprocessor failure:

2023-02-18T16:03:44.512566091Z level=error msg="Failed to compile bpf_lxc.dbg.o: exit status 1" compiler-pid=569 linker-pid=573 subsys=datapath-loader
2023-02-18T16:03:44.512582579Z level=warning msg="/var/lib/cilium/bpf/bpf_lxc.c:721:6: error: expected value in expression" subsys=datapath-loader
2023-02-18T16:03:44.512584803Z level=warning msg="#elif" subsys=datapath-loader
2023-02-18T16:03:44.512586851Z level=warning msg="     ^" subsys=datapath-loader
2023-02-18T16:03:44.512588449Z level=warning msg="/var/lib/cilium/bpf/bpf_lxc.c:1217:6: error: expected value in expression" subsys=datapath-loader
2023-02-18T16:03:44.512589996Z level=warning msg="#elif" subsys=datapath-loader
2023-02-18T16:03:44.512591526Z level=warning msg="     ^" subsys=datapath-loader
2023-02-18T16:03:44.512593196Z level=warning msg="2 errors generated." subsys=datapath-loader
2023-02-18T16:03:44.512676230Z level=debug msg="JoinEP: Failed to compile" debug=true error="Failed to compile bpf_lxc.dbg.o: exit status 1" params="&{Source:bpf_lxc.c Output:bpf_lxc.dbg.o OutputType:obj Options:[]}" subsys=datapath-loader

Odd that we don't catch this is make build or make build_all but must be a combination used for the particular failing ginkgo test: K8sPolicyTestExtended_Validate_toEntities_KubeAPIServer_Allows_connection_to_KubeAPIServer

[ldelossa]

/test

Job 'Cilium-PR-K8s-1.25-kernel-4.19' failed:

Click to show.

Test Name

K8sDatapathConfig Host firewall With VXLAN

Failure Output

FAIL: Failed to reach 192.168.56.11:80 from testserver-host-hb5lv

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19 so I can create one.

[ldelossa]

/test-1.25-4.19

[ldelossa]

/mlh new-flake Cilium-PR-K8s-1.25-kernel-4.19

[ldelossa]

/test-1.26-net-next

[ldelossa]

Spoke with @jibi and the net-next errors can be ignored, they are unrelated to this PR.

[pchaigno]

Spoke with @jibi and the net-next errors can be ignored, they are unrelated to this PR.

Yep, they are another case of #15474 because Jenkins rebased to include the test changes from #23448 but you're PR branch doesn't include the functional changes. Merging.

[pchaigno]

I've changed the release-note label given there is no user-visible impact here.