Optimize GetControllerName for CNP #23717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
marseel
force-pushed
the
optimize_get_controller_name
branch
3 times, most recently
from
cf64b52
to
01b440c
Compare
|
Commit 01b440c75afd0045e579183169160a2ac576a9c8 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
marseel
force-pushed
the
optimize_get_controller_name
branch
from
01b440c
to
591e2a5
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
/test |
|
Can you help to rebase with master, so that the latest ConformanceGatewayAPI tests can be picked up? Thanks. |
Use strings.Builder instead of fmt.Sprintf(). Results: ``` benchmark old ns/op new ns/op delta BenchmarkCNPGetControllerName-10 338 206 -39.05% benchmark old allocs new allocs delta BenchmarkCNPGetControllerName-10 6 4 -33.33% benchmark old bytes new bytes delta BenchmarkCNPGetControllerName-10 464 432 -6.90% ``` Signed-off-by: Marcel Zieba <marcel.zieba@isovalent.com>
marseel
force-pushed
the
optimize_get_controller_name
branch
from
591e2a5
to
929421c
Compare
nathanjsweet
approved these changes
Feb 27, 2023
sayboras
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
aanm
approved these changes
Mar 6, 2023
|
/test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use strings.Builder instead of fmt.Sprintf().
Results:
Signed-off-by: Marcel Zięba marseel@gmail.com
Related: #19571