bpf: Remove unneeded orig_dip from ipv6_host_policy_egress #23724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no need to copy the IPv6 address to a local variable, because the packet data is not going to change. Just use the address from the packet headers directly. Signed-off-by: Maxim Mikityanskiy <maxim@isovalent.com>
gentoo-root
added
kind/cleanup
NikAleksandrov
approved these changes
Feb 14, 2023
pchaigno
approved these changes
Feb 14, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
|
@gentoo-root Thanks for your contribution! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to copy the IPv6 address to a local variable, because the packet data is not going to change. Just use the address from the packet headers directly.
Signed-off-by: Maxim Mikityanskiy maxim@isovalent.com
See #23577, it's the same change in another function.