Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in config.go #23731

Merged
merged 1 commit into from Mar 14, 2023
Merged

Fix typo in config.go #23731

merged 1 commit into from Mar 14, 2023

Conversation

meyskens
Copy link
Member

@meyskens meyskens commented Feb 14, 2023 •
edited

This fixes a typo in the config.go file:
CilliumEndpoint -> CiliumEndpoint

Signed-off-by: Maartje Eyskens maartje.eyskens@isovalent.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!
Fix a typo in pkg/option/config.go

(is there a way to say no release note is needed?)

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 14, 2023
@meyskens meyskens marked this pull request as ready for review February 14, 2023 10:34
@meyskens meyskens requested review from a team as code owners February 14, 2023 10:34
pippolo84
pippolo84 approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

ldelossa
ldelossa approved these changes Feb 14, 2023
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@meyskens meyskens added the release-note/misc This PR makes changes that have no direct user impact. label Feb 14, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 14, 2023
@meyskens
Copy link
Member Author

/test

@meyskens
Fix typo in config.go
95f8716 
This fixes a typo in the config.go file:
CilliumEndpoint -> CiliumEndpoint

Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
@jrajahalme jrajahalme merged commit 2d230b3 into cilium:master Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pippolo84 pippolo84 pippolo84 approved these changes

@ldelossa ldelossa ldelossa approved these changes

@jrajahalme jrajahalme jrajahalme approved these changes

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@meyskens @pippolo84 @ldelossa @jrajahalme