policy: mapstate should respect authType in dataPath equality #23780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Policy MapState needs to respect property authType when checking it for dataPath equality. Without this change, changing the auth type on existing CiliumNetworkPolicies isn't reflected in the eBPF policy map. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
the
release-note/bug
jrajahalme
approved these changes
Feb 15, 2023
|
/test |
|
/ci-verifier |
|
/test-runtime |
aditighag
reviewed
Feb 16, 2023
maintainer-s-little-helper
bot
added
ready-to-merge
pchaigno
requested changes
Feb 16, 2023
pchaigno
removed
the
ready-to-merge
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
added
release-note/misc
i don't think it's necessary due to the fact that this isn't a user facing feature yet. i changed the label to |
pchaigno
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Policy MapState needs to respect property authType when checking it for dataPath equality. Without this change, changing the auth type on existing CiliumNetworkPolicies isn't reflected in the eBPF policy map.