bpf: Remove flowlabel optimization for identity #23795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
sig/datapath
For IPv6 traffic, we use the flowlabel field to transfer the source security identity across nodes and avoid an ipcache lookup. This misuse of the flowlabel field can however conflict with legitimate uses such as [1]. This commit therefore removes this optimization. 1 - https://lpc.events/event/11/contributions/955/ Suggested-by: Daniel Borkmann <daniel@iogearbox.net> Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
remove-ipv6-flowlabel-optim
branch
from
00c9c05
to
b3ddf69
Compare
borkmann
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For IPv6 traffic, we use the flowlabel field to transfer the source security identity across nodes and avoid an ipcache lookup. This misuse of the flowlabel field can however conflict with legitimate uses such as https://lpc.events/event/11/contributions/955/. This commit therefore removes this optimization.