chore: generating eni limits for missing aws instances #23835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Commit d4143f3f99ed1414d7645cd66338b09e610510ab does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
dont-merge/needs-sign-off
github-actions
bot
added
the
kind/community-contribution
muratso
force-pushed
the
update-aws-eni-limits
branch
from
d4143f3
to
453f5f8
Compare
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
muratso
force-pushed
the
update-aws-eni-limits
branch
from
453f5f8
to
b9dbfc3
Compare
christarazi
added
area/eni
christarazi
approved these changes
Feb 17, 2023
Signed-off-by: Eric Ferreira <ericarlos23@gmail.com>
christarazi
force-pushed
the
update-aws-eni-limits
branch
from
b9dbfc3
to
990490f
Compare
|
/test |
|
Required reviews are in, all CI jobs are good. Marking this ready to merge. |
sayboras
added
the
ready-to-merge
|
Could this be back ported to v1.13 please ? |
christarazi
added
affects/v1.14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.
Fixes: <commit-id>tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Cilium does not have ENI limits defined for some AWS instance types.
Used aws cli command from limits.go file:
AWS_REGION=us-east-1 aws ec2 describe-instance-types | jq -r '.InstanceTypes[] | "\"\(.InstanceType)\": {Adapters: \(.NetworkInfo.MaximumNetworkInterfaces), IPv4: \(.NetworkInfo.Ipv4AddressesPerInterface), IPv6: \(.NetworkInfo.Ipv6AddressesPerInterface), HypervisorType: \"\(.Hypervisor)\"},"' | sort | sed "s/null//"Added
c7g.metal
m6idn.12xlarge
m6idn.16xlarge
m6idn.24xlarge
m6idn.2xlarge
m6idn.32xlarge
m6idn.4xlarge
m6idn.8xlarge
m6idn.large
m6idn.xlarge
m6in.12xlarge
m6in.16xlarge
m6in.24xlarge
m6in.2xlarge
m6in.32xlarge
m6in.4xlarge
m6in.8xlarge
m6in.large
m6in.xlarge
m7g.12xlarge
m7g.16xlarge
m7g.2xlarge
m7g.4xlarge
m7g.8xlarge
m7g.large
m7g.medium
m7g.metal
m7g.xlarge
r6idn.12xlarge
r6idn.16xlarge
r6idn.24xlarge
r6idn.2xlarge
r6idn.32xlarge
r6idn.4xlarge
r6idn.8xlarge
r6idn.large
r6idn.xlarge
r6in.12xlarge
r6in.16xlarge
r6in.24xlarge
r6in.2xlarge
r6in.32xlarge
r6in.4xlarge
r6in.8xlarge
r6in.large
r6in.xlarge
r7g.12xlarge
r7g.16xlarge
r7g.2xlarge
r7g.4xlarge
r7g.8xlarge
r7g.large
r7g.medium
r7g.metal
r7g.xlarge