Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CODEOWNERS: assign /pkg/auth to sig-servicemesh #23844

Merged
merged 1 commit into from Feb 17, 2023
Merged

CODEOWNERS: assign /pkg/auth to sig-servicemesh #23844

merged 1 commit into from Feb 17, 2023

Conversation

mhofstetter
Copy link
Member

These packages contain code specific to the servicemesh functionality

@mhofstetter
CODEOWNERS: assign /pkg/auth to sig-servicemesh
5f7ba3e 
These packages contain code specific to the servicemesh functionality

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter requested a review from a team as a code owner February 17, 2023 11:43
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 17, 2023
@mhofstetter mhofstetter added the release-note/misc This PR makes changes that have no direct user impact. label Feb 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 17, 2023
sayboras
sayboras approved these changes Feb 17, 2023
View reviewed changes
Copy link
Member

@sayboras sayboras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@sayboras
Copy link
Member

sayboras commented Feb 17, 2023 •
edited

CI is done as per below, no job is required ✔️. On behalf of servicemesh team, I am happy to own this package 💯

image

@sayboras sayboras added ready-to-merge This PR has passed all tests and received consensus from code owners to merge. sig/contributing Impacts contribution workflow, guidelines, and tools. labels Feb 17, 2023
@pchaigno pchaigno merged commit 89f9348 into cilium:master Feb 17, 2023
@mhofstetter mhofstetter deleted the pr/mhofstetter/pkg-auth-codeowner branch February 17, 2023 15:39
@sayboras sayboras mentioned this pull request Feb 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@sayboras sayboras sayboras approved these changes

@aditighag aditighag Awaiting requested review from aditighag aditighag was automatically assigned from cilium/contributing

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/contributing Impacts contribution workflow, guidelines, and tools.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhofstetter @sayboras @pchaigno