Mark tests as successful if they are not supposed to run #23847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In certain cases where the `bpf/` and `test/verifier` directories are unmodified, the `ci-verifier` tests can now be safely marked as successful. Previously, this was not possible because the `Sibz/github-status-action` was part of an unexecuted step due to the lack of changes in these directories, preventing the Github action from setting the commit status as successful. This commit updates the Github workflow to address this issue. Signed-off-by: André Martins <andre@cilium.io>
In certain cases where none of the following directories have changes: `pkg/**`, `daemon/**`, `bpf/**`, `test/l4lb/**`, `images/**`, the `ci-l4lb-*` tests can now be marked as successful. Previously, this was not possible because the `Sibz/github-status-action` was part of an unexecuted step due to the lack of changes in these directories, preventing the Github action from setting the commit status as successful. This commit updates the Github workflow to address this issue. Signed-off-by: André Martins <andre@cilium.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
aanm
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
ldelossa
approved these changes
Feb 17, 2023
sayboras
approved these changes
Feb 19, 2023
|
/test |
nbusseneau
approved these changes
Feb 21, 2023
|
After this PR is merged, seems like ci-verifier is still pending |
jibi
added a commit
that referenced
this pull request
Mar 1, 2023
this job is currently failing as the sha parameter of the github-status action is left unset, as we are skipping the "Retrieve pull request's base and head" step. This commit fixes this by setting the appropriate workflow sha variable in the previous step. Fixes: #23847 Signed-off-by: Gilberto Bertin <jibi@cilium.io>
aanm
pushed a commit
that referenced
this pull request
Mar 1, 2023
this job is currently failing as the sha parameter of the github-status action is left unset, as we are skipping the "Retrieve pull request's base and head" step. This commit fixes this by setting the appropriate workflow sha variable in the previous step. Fixes: #23847 Signed-off-by: Gilberto Bertin <jibi@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See per commit message