Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

operator: Clarify log msg for unmanaged pods #23855

Merged

Conversation

christarazi
Copy link
Member

It was difficult to tell if the Operator had detected an unmanaged pod,
but wasn't taking action. A closer look reveals that it seems to be a
case of copy-pasta. Found by investigating a CI failure sysdump.

Also, fix a typo on the way there.

Signed-off-by: Chris Tarazi chris@isovalent.com

It was difficult to tell if the Operator had detected an unmanaged pod,
but wasn't taking action. A closer look reveals that it seems to be a
case of copy-pasta. Found by investigating a CI failure sysdump.

Also, fix a typo on the way there.

Signed-off-by: Chris Tarazi <chris@isovalent.com>
@christarazi christarazi added kind/cleanup This includes no functional changes. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers. area/operator Impacts the cilium-operator component release-note/misc This PR makes changes that have no direct user impact. labels Feb 17, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 17, 2023
@christarazi christarazi marked this pull request as ready for review February 17, 2023 17:01
@christarazi christarazi requested a review from a team as a code owner February 17, 2023 17:01
Copy link
Contributor

@nickolaev nickolaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense.

@joestringer joestringer merged commit de964f0 into cilium:master Feb 24, 2023
@christarazi christarazi deleted the pr/christarazi/operator-fix-dbg-log branch March 6, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/operator Impacts the cilium-operator component kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. sig/k8s Impacts the kubernetes API, or kubernetes -> cilium internals translation layers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants