bpf: nodeport: fix handling of stale CT entry with CT_REPLY #23894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
julianwiedmann
added
kind/bug
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The nodeport code creates its own CT entry for a service connection to a non-DSR backend. While doing so, the initial CT lookup might find a stale (non-nodeport) CT entry that needs to be re-created. CT_REPLY in particular needs consideration here - regardless of the entry's rev_nat_index, we don't expect incoming SVC requests to be a *reply* to some existing connection. So we always need to re-create such entries. Typically ct_create() is only called after the lookup returned a CT_NEW ct_status. Meaning that the CT tuple was already flipped by ct_lookup(). If we also call ct_create() after CT_REPLY, then the tuple needs to be flipped first. Otherwise the new CT entry is created for a tuple in the wrong direction. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
force-pushed
the
1.14-nodeport-stale-ct-entry
branch
from
d5940b1
to
fc087cf
Compare
|
/test |
|
/test-1.25-4.19 |
gentoo-root
approved these changes
Mar 2, 2023
julianwiedmann
added
the
ready-to-merge
borkmann
approved these changes
Mar 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drive-by fix for a weird corner case in the nodeport CT code.