Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Promote Deny Policies out of Beta #23921

Merged
merged 1 commit into from Feb 22, 2023

Conversation

nathanjsweet
Copy link
Member

Deny policies have been labeled as a "beta" feature in Cilium for a long time as they were not fully functional. Now that Deny policies have no major issues, they can be safely used as a non-beta feature.

Deny policies have been labelled as a "beta" feature
in Cilium for a long time as they were not fully functional.
Now that Deny policies have no major issues to speak of they
can be safely used as a non-beta feature.

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
@nathanjsweet nathanjsweet added the release-note/misc This PR makes changes that have no direct user impact. label Feb 21, 2023
@nathanjsweet nathanjsweet requested review from a team as code owners February 21, 2023 20:44
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@qmonnet qmonnet added the area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. label Feb 22, 2023
@qmonnet
Copy link
Member

qmonnet commented Feb 22, 2023

Minor change in docs, no need for the full CI run.

Not sure about the release-note label; there's not technical change in Cilium, but does coming out of beta qualifies for misc or for some minor change? 🤔

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 22, 2023
@margamanterola
Copy link
Member

One could argue that a specific feature going from Beta to Stable even warrants a "major" release note label. This is something that we would include in our release blog post, isn't it?

@nathanjsweet
Copy link
Member Author

@margamanterola I've updated the original PR to to have the "release-note/major" label, and it has a release note for promoting Deny policies from beta to stable. Does that work?

@margamanterola
Copy link
Member

Yeah, I guess that's fine.

@pchaigno pchaigno merged commit c499fbf into master Feb 22, 2023
@pchaigno pchaigno deleted the pr/nathanjsweet/elevate-deny-policies-out-of-beta branch February 22, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants