CODEOWNERS: Fold cilium/health into cilium/sig-agent #23952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The health team is currently really small (two reviewers) and the code it owns is fairly basic Golang code; it shouldn't require any special knowledge. Let's therefore reduce the chances of blocking on reviews and fold the health codeowners into the sig-agent's. Suggested-by: Joe Stringer <joe@cilium.io> Signed-off-by: Paul Chaignon <paul@cilium.io>
That package currently falls back to the TopHat as a codeowner but the sig-agent team is probably better suited. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
area/health
aanm
approved these changes
Feb 22, 2023
joestringer
approved these changes
Feb 22, 2023
|
I think this PR missed running https://github.com/cilium/cilium/blob/master/Documentation/update-codeowners.sh |
|
Fixed at #23979. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit folds @cilium/health's codeowners into @cilium/sig-agent's. The second commit adds pkg/status/ to @cilium/sig-agent.