Update the comments about monitorNotify in the listener.go #23963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix comment error about monitorNotify in `pkg/datapath/ipcache/listener.go`. Signed-off-by: hxysayhi <51870525+hxysayhi@users.noreply.github.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
github-actions
bot
added
the
kind/community-contribution
sayboras
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
|
Commit eb59a820e4790b41432548b647d83f6563db2644 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
maintainer-s-little-helper
bot
added
the
dont-merge/needs-sign-off
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-sign-off
|
@hxysayhi thank you for the PR. Please remove the last commit. Thank you |
|
@aanm ok, it's done |
jrajahalme
approved these changes
Mar 9, 2023
jrajahalme
added
the
ready-to-merge
|
This PR fixes a comment, no code changes, so no need to run the CI. Marked as ready-to-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix comment error about monitorNotify in
pkg/datapath/ipcache/listener.go.Fixes: None