Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: nodeport cleanups #23965

Merged
merged 2 commits into from Mar 7, 2023
Merged

bpf: nodeport cleanups #23965

merged 2 commits into from Mar 7, 2023

Conversation

julianwiedmann
Copy link
Member

Some small cleanups to shrink down my features branch.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 23, 2023
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Feb 23, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 23, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title WIP bpf: nodeport cleanups bpf: nodeport cleanups Mar 3, 2023
@julianwiedmann julianwiedmann marked this pull request as ready for review March 3, 2023 07:37
@julianwiedmann julianwiedmann requested a review from a team as a code owner March 3, 2023 07:37
@julianwiedmann
bpf: dsr: clarify endianness in DSR tail calls
001cbea 
The address and port are passed via CB in network-order, and that's also
what the various low-level functions expect. Clarify the types.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: clean up ctx_adjust_hroom_flags() variants
3ee7d75 
We have two implementations (for DSR and SRv6) that do the same thing.
Consolidate them.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
Copy link
Member Author

/test

dylandreimerink
dylandreimerink approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanups!

@julianwiedmann julianwiedmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 7, 2023
@YutaroHayakawa YutaroHayakawa merged commit c09ee90 into cilium:master Mar 7, 2023
@julianwiedmann julianwiedmann deleted the 1.14-nodeport-cleanups branch March 8, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dylandreimerink dylandreimerink dylandreimerink approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julianwiedmann @dylandreimerink @YutaroHayakawa