resource: Add Resource[Endpoints] and adapt existing watchers #23977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
release-note/misc
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
2 times, most recently
from
326c10a
to
01d77ee
Compare
|
This pull request has been automatically marked as stale because it |
github-actions
bot
added
the
stale
|
This pull request has not seen any activity since it was marked stale. |
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
01d77ee
to
076a3d8
Compare
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
076a3d8
to
6a4a97d
Compare
github-actions
bot
removed
the
stale
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
6a4a97d
to
39cabe5
Compare
joamaki
commented
May 15, 2023
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
39cabe5
to
ee57c6e
Compare
|
/test |
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
348f9ac
to
c71a567
Compare
YutaroHayakawa
approved these changes
May 26, 2023
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
c71a567
to
2fbc948
Compare
|
/test |
christarazi
added
area/daemon
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
2fbc948
to
bfbf7fc
Compare
|
/test |
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
bfbf7fc
to
33984b4
Compare
ldelossa
approved these changes
May 31, 2023
|
/test Job 'Cilium-PR-K8s-1.26-kernel-net-next' failed: Click to show.Test NameFailure OutputJenkins URL: https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/351/ If it is a flake and a GitHub issue doesn't already exist to track it, comment Then please upload the Jenkins artifacts to that issue. |
|
/test-1.26-net-next |
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
33984b4
to
e7257e8
Compare
|
/test |
|
Oh, it conflicts again. @joamaki can't I get the write access to your fork (maybe it's hard)? So that I can take care of resolve conflict and trigger the CI while you are sleeping. |
Add the option to transform the object before it's added to the store. Useful in situations where we want to store a subset of the data or a derivate object vs the upstream object. Signed-off-by: Jussi Maki <jussi@isovalent.com>
In preparation of making endpoints a Resource, allow transforming K8s Endpoints/EndpointSlices into our internal representation (k8s.Endpoints) and to store it in cache.Store, this adds the object metadata to it. The "EndpointSliceID" is included in k8s.Endpoints so it doesn't need to be passed separately. Signed-off-by: Jussi Maki <jussi@isovalent.com>
Add Resource[*Endpoints] which probes the api-server capabilities to pick the right upstream resource kind and expose endpoints with our internal type rather than requiring each use-site to figure this out on their own. Signed-off-by: Jussi Maki <jussi@isovalent.com>
- Remove endpoint and endpoint_slice watchers - Add "endpoints watcher" adapted from endpoint_slice watcher that uses Resource[*Endpoints] instead of informer. This keeps things the same downstream. - Adapts BGP speaker to only handle *k8s.Endpoints - Removes endpoint/endpointslice informers from operator and use resource instead Closes: cilium#23734 Signed-off-by: Jussi Maki <jussi@isovalent.com>
This was used by the EndpointSlice watcher to check whether there really existed an EndpointSlice in addition to the API server supporting them. Since EndpointSlices have been the default for many versions now, we don't need this level of paranoia. Signed-off-by: Jussi Maki <jussi@isovalent.com>
joamaki
force-pushed
the
pr/joamaki/endpoints-resource
branch
from
e7257e8
to
ed3573b
Compare
|
/test |
|
|
|
/test-1.16-4.19 |
joamaki
added
the
ready-to-merge
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
Resource[*Endpoints]which moves the resolving of the Endpoint or EndpointSlice into the constructor for the resource. K8sWatcher refactored to use theResource[*Endpoints]and code cleaned up to work with just*Endpointsrather than the 3 different kinds. Some messiness around collapsing them into one type and hiding the underlying resource kind. Please review those changes carefully (CachesSynced, metrics in endpoints watcher, ipcache.ResourceKindEndpoint). I've tried to keep existing behavior as much as I could, but could've potentially missed something.See individual commits and #23734 for motivation.