.gitattributes: Mark install/kubernetes/cilium/values.yaml as generated #24007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since commit 11333b2 ("install: Templatize image repositories and tags"), we've been using install/kubernetes/cilium/values.yaml.tmpl as a template to generate .../values.yaml, which should no longer be edited by hand. Pull Requests on GitHub usually display changes on the two files, but what we want instead is to see only the diff for the template (the CI should ensure that both files are in a consistent state). Signed-off-by: Quentin Monnet <quentin@isovalent.com>
qmonnet
added
the
release-note/misc
sayboras
added
the
ready-to-merge
|
Full CI is not required, marking this ready to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since commit 11333b2 ("install: Templatize image repositories and tags"), we've been using install/kubernetes/cilium/values.yaml.tmpl as a template to generate .../values.yaml, which should no longer be edited by hand. Pull Requests on GitHub usually display changes on the two files, but what we want instead is to see only the diff for the template (the CI should ensure that both files are in a consistent state).