Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auth: introduce hive cell (modularization) #24041

Merged
merged 1 commit into from Feb 28, 2023

Conversation

mhofstetter
Copy link
Member

The auth manager itself is defined as cell which gets registered in the cell "control plane".

This way, the daemon cell doesn't need to know about the details how to initialize the auth manager and its internal components.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 27, 2023
@mhofstetter mhofstetter added the release-note/misc This PR makes changes that have no direct user impact. label Feb 27, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 27, 2023
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, will be using this a template going forward!

pkg/auth/cell.go Outdated Show resolved Hide resolved
pkg/auth/cell.go Show resolved Hide resolved
daemon/cmd/policy.go Show resolved Hide resolved
@mhofstetter mhofstetter marked this pull request as ready for review February 27, 2023 14:00
@mhofstetter mhofstetter requested review from a team as code owners February 27, 2023 14:00
@mhofstetter
Copy link
Member Author

/test

@mhofstetter
Copy link
Member Author

k8s e2e test failures due to #24045

going to rebase to master and re-run once this has been merged

The auth manager itself is defined as cell which gets registered in the
cell "control plane".

This way, the daemon cell doesn't need to know about the details how to
initialize the auth manager and its internal components.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter
Copy link
Member Author

/test

@mhofstetter
Copy link
Member Author

mhofstetter commented Feb 28, 2023

not automatically triggered / reported

/ci-verifier

Copy link
Member

@pippolo84 pippolo84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Feb 28, 2023
@sayboras sayboras merged commit 60ba1cf into cilium:master Feb 28, 2023
@mhofstetter mhofstetter deleted the pr/mhofstetter/auth-hive-cell branch February 28, 2023 15:05
@mhofstetter mhofstetter added the area/servicemesh GH issues or PRs regarding servicemesh label Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/servicemesh GH issues or PRs regarding servicemesh ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants