New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
auth: introduce hive cell (modularization) #24041
auth: introduce hive cell (modularization) #24041
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, will be using this a template going forward!
e98f15a
to
8c7843a
Compare
8c7843a
to
e898ff6
Compare
/test |
k8s e2e test failures due to #24045 going to rebase to master and re-run once this has been merged |
The auth manager itself is defined as cell which gets registered in the cell "control plane". This way, the daemon cell doesn't need to know about the details how to initialize the auth manager and its internal components. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
e898ff6
to
ac7494b
Compare
/test |
not automatically triggered / reported /ci-verifier |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
The auth manager itself is defined as cell which gets registered in the cell "control plane".
This way, the daemon cell doesn't need to know about the details how to initialize the auth manager and its internal components.