Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "kludge: hardcode Google Cloud SDK key due to error 500" #24060

Merged
merged 1 commit into from Feb 28, 2023
Merged

Revert "kludge: hardcode Google Cloud SDK key due to error 500" #24060

merged 1 commit into from Feb 28, 2023

Conversation

sayboras
Copy link
Member

Reverts #24045

@maintainer-s-little-helper
Copy link

Commit aa4ea0157d39640dbe529234148bc0c0aaf868f6 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 28, 2023
@sayboras
Revert "kludge: hardcode Google Cloud SDK key due to error 500"
0f5b416 
This reverts commit 160ec52.

Signed-off-by: Tam Mach <tam.mach@cilium.io>
@sayboras sayboras force-pushed the revert-24045-pr/google-cloud-sdk-key-kludge branch from aa4ea01 to 0f5b416 Compare February 28, 2023 08:30
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Feb 28, 2023
@sayboras sayboras added the release-note/misc This PR makes changes that have no direct user impact. label Feb 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 28, 2023
@sayboras sayboras added area/CI Continuous Integration testing issue or flake dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Feb 28, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 28, 2023
@sayboras sayboras marked this pull request as ready for review February 28, 2023 08:30
@sayboras sayboras requested a review from a team as a code owner February 28, 2023 08:30
@sayboras sayboras requested a review from nebril February 28, 2023 08:30
@sayboras
Copy link
Member Author

sayboras commented Feb 28, 2023 •
edited

Full CI is not required as this is a revert of temp fix. The revert is done via git revert but not manual.

@sayboras sayboras merged commit 425c2a3 into master Feb 28, 2023
@sayboras sayboras deleted the revert-24045-pr/google-cloud-sdk-key-kludge branch February 28, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pchaigno pchaigno pchaigno approved these changes

@nebril nebril Awaiting requested review from nebril nebril was automatically assigned from cilium/ci-structure

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sayboras @pchaigno