bpf: handle VLAN before XDP meta-data in from-netdev #24063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VLAN traffic entering from-netdev@eth0 either gets dropped, or immediately handed back to the stack with CTX_ACT_OK. We then expect to process the packet a second time in from-netdev@eth0.vlanXXX. Move this logic back to the front of from-netdev, before handling any potential meta_data that was passed up by the XDP program. In practice this doesn't fix anything - our XDP program currently doesn't handle VLAN traffic at all, and just passes it up without setting any meta_data. So we merely clarify the intent, and restore old behaviour. Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
julianwiedmann
added
sig/datapath
|
/test |
aspsk
approved these changes
Feb 28, 2023
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sanity mostly - I needed to walk down that code path recently, and was worried whether we could end up accidentally taking the redirect-to-tunnel case while the VLAN header is still on. So let's clean it up, before it ends up causing us trouble later on. |
Yes, makes sense |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VLAN traffic entering from-netdev@eth0 either gets dropped, or immediately handed back to the stack with CTX_ACT_OK. We then expect to process the packet a second time in from-netdev@eth0.vlanXXX.
Move this logic back to the front of from-netdev, before handling any potential meta_data that was passed up by the XDP program.
In practice this doesn't fix anything - our XDP program currently doesn't handle VLAN traffic at all, and just passes it up without setting any meta_data. So we merely clarify the intent, and restore old behaviour.