Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: l4lb/verifier: fix skip-test-run job #24072

Merged
merged 1 commit into from Mar 1, 2023

Conversation

jibi
Copy link
Member

@jibi jibi commented Feb 28, 2023

this job is currently failing as the sha parameter of the github-status
action is left unset, as we are skipping the "Retrieve pull request's
base and head" step.

This commit fixes this by setting the appropriate workflow sha variable
in the previous step.

@jibi jibi added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Feb 28, 2023
@jibi jibi force-pushed the pr/jibi/fix-skipped-workflows-status branch 7 times, most recently from 01ddcf2 to 7e86eea Compare February 28, 2023 14:11
@jibi jibi requested review from aanm and nbusseneau February 28, 2023 14:12
@jibi jibi marked this pull request as ready for review February 28, 2023 14:12
@jibi jibi requested review from a team as code owners February 28, 2023 14:12
this job is currently failing as the sha parameter of the github-status
action is left unset, as we are skipping the "Retrieve pull request's
base and head" step.

This commit fixes this by setting the appropriate workflow sha variable
in the previous step.

Fixes: #23847
Signed-off-by: Gilberto Bertin <jibi@cilium.io>
@jibi jibi force-pushed the pr/jibi/fix-skipped-workflows-status branch from 7e86eea to 7a8fc3a Compare March 1, 2023 11:37
Copy link
Member

@aanm aanm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aanm aanm merged commit 91748f0 into master Mar 1, 2023
@aanm aanm deleted the pr/jibi/fix-skipped-workflows-status branch March 1, 2023 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants