Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: Add hubble-ui ingress labels #24077

Merged
merged 1 commit into from Mar 21, 2023

Conversation

ReillyBrogan
Copy link
Contributor

Support additional labels in the hubble-ui ingress definition.

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

Some Ingress controllers (Traefik for example) support using labels for selecting which ingresses to serve from a particular ingress controller. This adds support for that.

helm: Add support of additional labels to hubble ui ingress

@ReillyBrogan ReillyBrogan requested review from a team as code owners February 28, 2023 17:57
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Feb 28, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Feb 28, 2023
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There seems to be a typo in the generated files. From CI:

--- a/Documentation/helm-values.rst
+++ b/Documentation/helm-values.rst
@@ -1228,7 +1228,7 @@
    * - hubble.ui.ingress
      - hubble-ui ingress configuration.
      - object
-     - ``{"annotations":{},"className":"","enabled":false,"hosts":["chart-example.local"],"labels":{},""tls":[]}``
+     - ``{"annotations":{},"className":"","enabled":false,"hosts":["chart-example.local"],"labels":{},"tls":[]}``
    * - hubble.ui.nodeSelector
      - Node labels for pod assignment ref: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector
      - object
HINT: to fix this, run 'make -C Documentation update-helm-values'

Copy link
Contributor

@tommyp1ckles tommyp1ckles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg, aside from some CI linting issues?

@gandro gandro added release-note/misc This PR makes changes that have no direct user impact. area/helm Impacts helm charts and user deployment experience labels Mar 15, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 15, 2023
@gandro
Copy link
Member

gandro commented Mar 15, 2023

@ReillyBrogan Could you rebase this branch on master? It seems to be lagging a bit behind, thereby causing some CI failures due to tests requiring a more recent code base. Thanks.

Support additional labels in the hubble-ui ingress definition.

Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Let's run CI

@gandro
Copy link
Member

gandro commented Mar 16, 2023

/test

@gandro
Copy link
Member

gandro commented Mar 20, 2023

Runtime and and net-next failed while accessing GitHub. Restarting.
stderr: fatal: unable to access 'https://github.com/cilium/cilium/': Failed to connect to github.com port 443: Connection timed out
https://jenkins.cilium.io/job/Cilium-PR-Runtime-net-next/5573/console
https://jenkins.cilium.io/job/Cilium-PR-K8s-1.26-kernel-net-next/1332/console

GKE timed out deleting a namespace - flake #22368
⌛ Waiting for cilium-test namespace to be terminated...
https://github.com/cilium/cilium/actions/runs/4435492293/jobs/7782713809

Restarting too.

@gandro
Copy link
Member

gandro commented Mar 20, 2023

/ci-gke

@gandro
Copy link
Member

gandro commented Mar 20, 2023

/test-1.26-net-next

@gandro
Copy link
Member

gandro commented Mar 20, 2023

/test-runtime

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 20, 2023
@youngnick youngnick merged commit c7ba409 into cilium:master Mar 21, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/helm Impacts helm charts and user deployment experience kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants