New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: Add hubble-ui ingress labels #24077
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a typo in the generated files. From CI:
--- a/Documentation/helm-values.rst
+++ b/Documentation/helm-values.rst
@@ -1228,7 +1228,7 @@
* - hubble.ui.ingress
- hubble-ui ingress configuration.
- object
- - ``{"annotations":{},"className":"","enabled":false,"hosts":["chart-example.local"],"labels":{},""tls":[]}``
+ - ``{"annotations":{},"className":"","enabled":false,"hosts":["chart-example.local"],"labels":{},"tls":[]}``
* - hubble.ui.nodeSelector
- Node labels for pod assignment ref: https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/#nodeselector
- object
HINT: to fix this, run 'make -C Documentation update-helm-values'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lg, aside from some CI linting issues?
c43944a
to
9534867
Compare
@ReillyBrogan Could you rebase this branch on master? It seems to be lagging a bit behind, thereby causing some CI failures due to tests requiring a more recent code base. Thanks. |
Support additional labels in the hubble-ui ingress definition. Signed-off-by: Reilly Brogan <reilly@reillybrogan.com>
9534867
to
e16fe1f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Let's run CI
/test |
Runtime and and net-next failed while accessing GitHub. Restarting. GKE timed out deleting a namespace - flake #22368 Restarting too. |
/ci-gke |
/test-1.26-net-next |
/test-runtime |
Support additional labels in the hubble-ui ingress definition.
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
Fixes: <commit-id>
tag, thenplease add the commit author[s] as reviewer[s] to this issue.
Some Ingress controllers (Traefik for example) support using labels for selecting which ingresses to serve from a particular ingress controller. This adds support for that.