vendor,test: Updated CoverBee to v0.3.1 to resolve panic during testing #24094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylandreimerink
added
the
release-note/misc
tklauser
approved these changes
Mar 1, 2023
tklauser
added
the
dont-merge/needs-rebase
|
@dylandreimerink it looks like this needs a rebase now that Go 1.20 is used in |
sayboras
approved these changes
Mar 1, 2023
We were getting panics in the CoverBee code when coverage testing certain test programs. It turns out that this was due to "dead code" which the verifier would never evaluate, which CoverBee did not expect to be possible. This version of CoverBee fixes the issue without additional changes. Fixes: cilium#24053 Signed-off-by: Dylan Reimerink <dylan.reimerink@isovalent.com>
dylandreimerink
force-pushed
the
feature/coverbee-handle-deadcode
branch
from
579d596
to
f339933
Compare
tklauser
removed
the
dont-merge/needs-rebase
|
BPF unit tests passed on #23291 with this change pulled in: https://github.com/cilium/cilium/actions/runs/4302018934 Marking as ready to merge to unblock #23291. |
tklauser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were getting panics in the CoverBee code when coverage testing certain test programs. It turns out that this was due to "dead code" which the verifier would never evaluate, which CoverBee did not expect to be possible.
This version of CoverBee fixes the issue without additional changes.
Fixes: #24053