Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: remove a redundant IPcache lookup in from-host #24107

Merged
merged 2 commits into from Mar 2, 2023
Merged

bpf: remove a redundant IPcache lookup in from-host #24107

merged 2 commits into from Mar 2, 2023

Conversation

julianwiedmann
Copy link
Member

@julianwiedmann julianwiedmann commented Mar 1, 2023 •
edited

Two little cleanups for the from-host path in bpf_host. We've tried these before, but back then the 4.9 verifier didn't like it.

@julianwiedmann
bpf: remove redundant IPcache lookup in from-host path
26f8f3a 
We first look up the destination endpoint to check for tunnel redirection,
and then look it up a second time to access its sec_label and IPSec key.

Make the first look-up unconditional, so that we can remove the second.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann
bpf: remove redundant NULL check after IPCache lookup in from-host path
98b56dd 
There is a `info == NULL` check just a few lines earlier. The verifier
should be smart enough to understand that we don't need this again.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 1, 2023
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Mar 1, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 1, 2023
@julianwiedmann
Copy link
Member Author

/test

@julianwiedmann julianwiedmann changed the title WIP from-host bpf: remove a redundant IPcache lookup in from-host Mar 1, 2023
@julianwiedmann julianwiedmann marked this pull request as ready for review March 1, 2023 14:38
@julianwiedmann julianwiedmann requested a review from a team as a code owner March 1, 2023 14:38
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 2, 2023
@aanm aanm merged commit 9728358 into cilium:master Mar 2, 2023
@julianwiedmann julianwiedmann deleted the bpf-prog-host branch March 2, 2023 14:38
@julianwiedmann julianwiedmann mentioned this pull request Mar 5, 2024
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aspsk aspsk aspsk approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julianwiedmann @aspsk @aanm