Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

daemon: use the real err instead of a nil one #24115

Merged
merged 1 commit into from Mar 3, 2023

Conversation

spacewander
Copy link
Contributor

An incorrect 'nil' error was used instead of the real err returned from NewPreFilter.
Signed-off-by: spacewander spacewanderlzx@gmail.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 1, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 1, 2023
An incorrect 'nil' error was used instead of the real err returned from
NewPreFilter.
Signed-off-by: spacewander <spacewanderlzx@gmail.com>
@spacewander spacewander marked this pull request as ready for review March 1, 2023 14:25
@spacewander spacewander requested a review from a team as a code owner March 1, 2023 14:25
@spacewander spacewander requested a review from rgo3 March 1, 2023 14:25
@spacewander
Copy link
Contributor Author

It seems the failed CI is not relative to this change.

@rgo3
Copy link
Contributor

rgo3 commented Mar 1, 2023

Yes, ConformanceGatewayAPI hit #23999. I'll trigger a rerun.

@rgo3
Copy link
Contributor

rgo3 commented Mar 1, 2023

/test

Job 'Cilium-PR-K8s-1.24-kernel-5.4' failed:

Click to show.

Test Name

K8sDatapathConfig Host firewall With VXLAN

Failure Output

FAIL: Failed to reach 192.168.56.11:80 from testclient-mh4td

If it is a flake and a GitHub issue doesn't already exist to track it, comment /mlh new-flake Cilium-PR-K8s-1.24-kernel-5.4 so I can create one.

@spacewander
Copy link
Contributor Author

Thanks!
It seems to be a known flake:
#16122

@rgo3
Copy link
Contributor

rgo3 commented Mar 2, 2023

/test-1.24-5.4

@rgo3 rgo3 added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 2, 2023
@rgo3
Copy link
Contributor

rgo3 commented Mar 2, 2023

Thanks for looking up the flake and fixing this @spacewander. I triggered a rerun and approved 👍

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 2, 2023
@YutaroHayakawa YutaroHayakawa merged commit 7eb0564 into cilium:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants