Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hubble: traffic direction filter #24120

Merged
merged 2 commits into from Mar 3, 2023
Merged

hubble: traffic direction filter #24120

merged 2 commits into from Mar 3, 2023

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Mar 1, 2023

Before this patch, filtering Hubble flows by traffic direction (e.g. ingress or egress) was not possible.

@kaworu
doc: fix incomplete sentence in policy creation tutorial
173642c 
Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@kaworu
hubble: add traffic direction filtering
d6baa8f 
Before this patch, filtering Hubble flows by traffic direction (e.g.
ingress or egress) was not possible.

Signed-off-by: Alexandre Perrin <alex@isovalent.com>
@kaworu kaworu added kind/feature This introduces new functionality. release-note/misc This PR makes changes that have no direct user impact. sig/hubble Impacts hubble server or relay labels Mar 1, 2023
@kaworu kaworu requested review from a team as code owners March 1, 2023 15:08
qmonnet
qmonnet approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But what if I want to next steps??

@qmonnet
Copy link
Member

qmonnet commented Mar 1, 2023

There's some user impact here, maybe switch to release-note/minor?

gandro
gandro approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaworu kaworu added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. and removed release-note/misc This PR makes changes that have no direct user impact. labels Mar 1, 2023
@kaworu
Copy link
Member Author

kaworu commented Mar 1, 2023

/test

aditighag
aditighag approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@aditighag aditighag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kaworu
Copy link
Member Author

kaworu commented Mar 2, 2023 •
edited

/test-1.24-5.4

EDIT: previous run hit #22578

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 2, 2023
@YutaroHayakawa YutaroHayakawa merged commit 9570f8c into cilium:master Mar 3, 2023
@kaworu kaworu deleted the pr/kaworu/hubble/traffic-direction-filter branch March 3, 2023 08:32
@kaworu kaworu mentioned this pull request Apr 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@chancez chancez chancez approved these changes

@qmonnet qmonnet qmonnet approved these changes

@aditighag aditighag aditighag approved these changes

@michi-covalent michi-covalent michi-covalent approved these changes

Assignees
No one assigned
Labels
kind/feature This introduces new functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. sig/hubble Impacts hubble server or relay
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@kaworu @qmonnet @gandro @chancez @aditighag @michi-covalent @YutaroHayakawa