Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: Cover IPsec + GENEVE #24125

Merged
merged 1 commit into from Mar 7, 2023

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Mar 1, 2023

Daniel recently reported a bug that might be affecting IPsec + GENEVE. We don't have any coverage for that configuration so let's add some. We can convert one of the two IPsec + VXLAN configurations from the datapath workflow for that.

Passing test: https://github.com/cilium/cilium/actions/runs/4322605721/jobs/7545223283.

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. release-note/ci This PR makes changes to the CI. labels Mar 1, 2023
@brb
Copy link
Member

brb commented Mar 2, 2023

Check the 230 line 😬

TUNNEL="--helm-set-string=tunnel=vxlan"

@pchaigno pchaigno force-pushed the pr/pchaigno/tests-cover-geneve-ipsec branch 3 times, most recently from 538348f to a3f717a Compare March 3, 2023 15:54
@pchaigno pchaigno marked this pull request as ready for review March 3, 2023 15:54
@pchaigno pchaigno requested review from a team as code owners March 3, 2023 15:54
Daniel recently reported a bug that might be affecting IPsec + GENEVE.
We don't have any coverage for that configuration so let's add some. We
can convert one of the two IPsec + VXLAN configurations from the
datapath workflow for that.

Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno force-pushed the pr/pchaigno/tests-cover-geneve-ipsec branch from a3f717a to bcd70eb Compare March 6, 2023 14:51
@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 6, 2023
@YutaroHayakawa YutaroHayakawa merged commit 4f2a3d4 into master Mar 7, 2023
@YutaroHayakawa YutaroHayakawa deleted the pr/pchaigno/tests-cover-geneve-ipsec branch March 7, 2023 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants