Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Link Security Team #24135

Merged
merged 1 commit into from Mar 2, 2023
Merged

Fix: Link Security Team #24135

merged 1 commit into from Mar 2, 2023

Conversation

xmulligan
Copy link
Member

No description provided.

@xmulligan
Fix: Link Security Team
fa0b0ac 
Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@xmulligan xmulligan requested a review from a team as a code owner March 2, 2023 12:39
@xmulligan xmulligan requested a review from nebril March 2, 2023 12:39
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 2, 2023
@xmulligan xmulligan mentioned this pull request Mar 2, 2023
Closed
@xmulligan xmulligan requested review from lizrice and tgraf March 2, 2023 12:40
@xmulligan xmulligan added the release-note/misc This PR makes changes that have no direct user impact. label Mar 2, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 2, 2023
lizrice
lizrice approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@lizrice lizrice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You probably already have this on your to-do list, but we need to list the security team members in the file this links to

joestringer
joestringer approved these changes Mar 2, 2023
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably update this also to offer to report via https://github.com/cilium/cilium/security/advisories/new as an alternative to email, but that's a separate question. This change LGTM.

@joestringer joestringer merged commit 6d68670 into master Mar 2, 2023
@joestringer joestringer deleted the xmulligan-patch-2 branch March 2, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lizrice lizrice lizrice approved these changes

@joestringer joestringer joestringer approved these changes

@nebril nebril Awaiting requested review from nebril nebril was automatically assigned from cilium/contributing

@tgraf tgraf Awaiting requested review from tgraf

Assignees
No one assigned
Labels
release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xmulligan @lizrice @joestringer