Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/service: unify service list/get output #24136

Merged
merged 1 commit into from Mar 6, 2023
Merged

cmd/service: unify service list/get output #24136

merged 1 commit into from Mar 6, 2023

Conversation

oblazek
Copy link
Contributor

@oblazek oblazek commented Mar 2, 2023 •
edited

Previously cilium service get command did not show the state of each backend.

This commit unifies the outputs to use a single function where the formatting is defined.

before:

# cilium service get 3043
10.32.95.217:6379 =>
		1 => 10.246.1.34:42069 (3043)
		2 => 10.249.92.40:42069 (3043)
		3 => 10.246.3.34:42069 (3043)

after:

# cilium service get 3043
ID     Frontend            Service Type   Backend                                 
3043   10.32.95.217:6379   NodePort       1 => 10.246.1.34:42069 (active)         
                                          2 => 10.249.92.40:42069 (maintenance)   
                                          3 => 10.246.3.34:42069 (active)

Signed-off-by: Ondrej Blazek ondrej.blazek@firma.seznam.cz

@oblazek oblazek requested a review from a team as a code owner March 2, 2023 13:45
@oblazek oblazek requested a review from squeed March 2, 2023 13:45
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 2, 2023
@github-actions github-actions bot added the kind/community-contribution This was a contribution made by a community member. label Mar 2, 2023
@oblazek oblazek force-pushed the ob-unify-service-get-output branch from c75d90c to 2226a58 Compare March 2, 2023 14:48
@joamaki joamaki added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Mar 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 3, 2023
@oblazek
cmd/service: unify service list/get output
6e4b512 
Previously `cilium service get` command did not show the state
of each backend.

This commit unifies the outputs to use a single function where
the formatting is defined.

Signed-off-by: Ondrej Blazek <ondrej.blazek@firma.seznam.cz>
@oblazek oblazek force-pushed the ob-unify-service-get-output branch from 2226a58 to 6e4b512 Compare March 6, 2023 09:30
@borkmann
Copy link
Member

borkmann commented Mar 6, 2023

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 6, 2023
@borkmann borkmann merged commit e9eb17e into cilium:master Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squeed squeed squeed approved these changes

@borkmann borkmann borkmann approved these changes

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
kind/community-contribution This was a contribution made by a community member. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@oblazek @borkmann @squeed @joamaki