Aspsk/pr/make cilium monitor great again #24143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit bb5e3fe "improved" the output of 'cilium monitor -t drop' so that file ids were used since in the report: xx drop (Invalid packet) flow 0x0 to endpoint 0, ifindex 12, file 101:80, ... xx drop (Policy denied) flow 0xeea42740 to endpoint 0, ifindex 14, file 2:1167, ... This turns out to be really inconvenient, so switch back to file names. Now output looks more readable, like this: xx drop (Invalid source ip) flow 0x0 to endpoint 0, ifindex 8, file bpf_lxc.c:734, ... xx drop (Unknown L3 target address) flow 0x0 to endpoint 0, ifindex 8, file lib/icmp6.h:413, ... xx drop (Invalid source ip) flow 0x0 to endpoint 0, ifindex 10, file bpf_lxc.c:734, ... The pkg/datapath/loader/check-sources.sh script was adjusted to check that file names are synced between C and Go. Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
Script ignored the error code in some cases, only printed the error message. Fix this. Signed-off-by: Anton Protopopov <aspsk@isovalent.com>
aspsk
added
the
release-note/minor
borkmann
approved these changes
Mar 2, 2023
rgo3
approved these changes
Mar 2, 2023
NikAleksandrov
approved these changes
Mar 2, 2023
aspsk
added
the
ready-to-merge
|
Marked as ready-to-merge, as this change doesn't require the full test suite. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit bb5e3fe "improved" the output of 'cilium monitor -t drop'
so that file ids were used since in the report:
This turns out to be really inconvenient, so switch back to file names. Now
output looks more readable, like this:
The pkg/datapath/loader/check-sources.sh script was adjusted to check that file
names are synced between C and Go.