New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
golangci-lint: Update to v1.51.2 #24153
Merged
YutaroHayakawa
merged 3 commits into
cilium:master
from
mhofstetter:pr/mhofstetter/golangci-lint-1.51.2
Mar 7, 2023
Merged
golangci-lint: Update to v1.51.2 #24153
YutaroHayakawa
merged 3 commits into
cilium:master
from
mhofstetter:pr/mhofstetter/golangci-lint-1.51.2
Mar 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 3, 2023
mhofstetter
added
the
release-note/misc
This PR makes changes that have no direct user impact.
label
Mar 3, 2023
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
The author needs to describe the release impact of these changes.
label
Mar 3, 2023
jibi
approved these changes
Mar 3, 2023
brlbil
approved these changes
Mar 3, 2023
tklauser
reviewed
Mar 3, 2023
kaworu
reviewed
Mar 6, 2023
Updating golangci-lint to latest version which fixes caching issues and therefore improves performance. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
removing deprecated linter varcheck which has been replaced with unused. Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
mhofstetter
force-pushed
the
pr/mhofstetter/golangci-lint-1.51.2
branch
from
March 6, 2023 12:29
52b5d4e
to
6b62290
Compare
kaworu
reviewed
Mar 6, 2023
dylandreimerink
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/test |
tklauser
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
maintainer-s-little-helper
bot
added
the
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
label
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ready-to-merge
This PR has passed all tests and received consensus from code owners to merge.
release-note/misc
This PR makes changes that have no direct user impact.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating golangci-lint to latest version improves performance when executing locally.
In addition, failing lint issues in LBIPAM have been fixed.