Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

golangci-lint: Update to v1.51.2 #24153

Merged

Conversation

mhofstetter
Copy link
Member

@mhofstetter mhofstetter commented Mar 3, 2023

Updating golangci-lint to latest version improves performance when executing locally.

In addition, failing lint issues in LBIPAM have been fixed.

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 3, 2023
@mhofstetter mhofstetter added the release-note/misc This PR makes changes that have no direct user impact. label Mar 3, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 3, 2023
@mhofstetter mhofstetter marked this pull request as ready for review March 3, 2023 11:10
@mhofstetter mhofstetter requested review from a team as code owners March 3, 2023 11:10
Makefile.defs Outdated Show resolved Hide resolved
Updating golangci-lint to latest version which fixes caching issues and
therefore improves performance.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
removing deprecated linter varcheck which has been replaced with unused.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/golangci-lint-1.51.2 branch from 52b5d4e to 6b62290 Compare March 6, 2023 12:29
Copy link
Member

@dylandreimerink dylandreimerink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mhofstetter
Copy link
Member Author

/test

Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 7, 2023
@YutaroHayakawa YutaroHayakawa merged commit a646acc into cilium:master Mar 7, 2023
@mhofstetter mhofstetter deleted the pr/mhofstetter/golangci-lint-1.51.2 branch March 7, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants