Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add User doc to PR Template #24186

Merged
merged 1 commit into from Mar 7, 2023
Merged

Add User doc to PR Template #24186

merged 1 commit into from Mar 7, 2023

Conversation

xmulligan
Copy link
Member

This might help us drive more users on the user page

@xmulligan xmulligan requested a review from a team as a code owner March 6, 2023 11:37
@xmulligan xmulligan requested a review from aditighag March 6, 2023 11:37
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 6, 2023
@xmulligan xmulligan added the release-note/misc This PR makes changes that have no direct user impact. label Mar 6, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 6, 2023
@@ -9,6 +9,7 @@ Please ensure your pull request adheres to the following guidelines:
please add the commit author[s] as reviewer[s] to this issue.
- [ ] All commits are signed off. See the section [Developer’s Certificate of Origin](https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#dev-coo)
- [ ] Provide a title or release-note blurb suitable for the release notes.
- [ ] Are you a users of Cilium? Please add yourself to the [Users doc](https://github.com/cilium/cilium/blob/master/USERS.md)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: a users of

Signed-off-by: Bill Mulligan <billmulligan516@gmail.com>
@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 7, 2023
@YutaroHayakawa YutaroHayakawa merged commit 1a3dd17 into master Mar 7, 2023
@YutaroHayakawa YutaroHayakawa deleted the xmulligan-patch-2 branch March 7, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants