Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh/workflows: enable egress gateway in ci-datapath #24210

Merged
merged 1 commit into from Mar 9, 2023

Conversation

lmb
Copy link
Contributor

@lmb lmb commented Mar 7, 2023

Enable the egress gateway in some datapath workflows. Doing this is
a bit tricky, since EGW relies on BPF masquerading to function. The
latter has been disabled to work around #23283. Instead, we can
force legacy host routing which has a similar effect.

Unfortunately, BPF masquerading doesn't work for IPv6 so enabling
it breaks a bunch of testcases! The solution is to run half of
the tests with BPF masq and EGW disabled, and the other half with
EGW on, BPF masq on and IPv6 masq disabled.

Updates #24151.

Enable egress gateway in datapath CI

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 7, 2023
@lmb lmb added the release-note/misc This PR makes changes that have no direct user impact. label Mar 7, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 7, 2023
@lmb lmb force-pushed the lmb/egw-tests-ci-datapath-update branch from 5e774e5 to 02c6a9a Compare March 7, 2023 10:41
@lmb
Copy link
Contributor Author

lmb commented Mar 7, 2023

/test

@brb
Copy link
Member

brb commented Mar 7, 2023

/test

@lmb MBOI - to trigger only the ci-datapath GHA you can type /ci-datapath. Also, for this PR changes only that GHA matters, so no need to run all tests.

@lmb
Copy link
Contributor Author

lmb commented Mar 7, 2023

@lmb lmb force-pushed the lmb/egw-tests-ci-datapath-update branch from 02c6a9a to 8042484 Compare March 7, 2023 14:12
@lmb lmb marked this pull request as ready for review March 7, 2023 14:13
@lmb lmb requested review from a team as code owners March 7, 2023 14:13
@lmb lmb changed the title gh/workflows: disable host routing instead of BPF masquerading gh/workflows: enable egress gateway in ci-datapath Mar 7, 2023
@lmb lmb force-pushed the lmb/egw-tests-ci-datapath-update branch from 8042484 to 9750d4b Compare March 7, 2023 15:49
@lmb
Copy link
Contributor Author

lmb commented Mar 7, 2023

/ci-datapath

@lmb lmb force-pushed the lmb/egw-tests-ci-datapath-update branch from 9750d4b to c641ea8 Compare March 7, 2023 16:24
@lmb
Copy link
Contributor Author

lmb commented Mar 7, 2023

/ci-datapath

@christarazi christarazi added area/CI Continuous Integration testing issue or flake sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/ci This PR makes changes to the CI. and removed release-note/misc This PR makes changes that have no direct user impact. labels Mar 8, 2023
Enable the egress gateway in some datapath workflows. Doing this is
a bit tricky, since EGW relies on BPF masquerading to function. The
latter has been disabled to work around #23283. Instead, we can
force legacy host routing which has a similar effect.

Unfortunately, BPF masquerading doesn't work for IPv6 so enabling
it breaks a bunch of testcases! The solution is to run half of
the tests with BPF masq and EGW disabled, and the other half with
EGW on, BPF masq on and IPv6 masq disabled.

Updates #24151.

Signed-off-by: Lorenz Bauer <lmb@isovalent.com>
@lmb lmb force-pushed the lmb/egw-tests-ci-datapath-update branch from 3592550 to d1240bb Compare March 8, 2023 10:26
@lmb
Copy link
Contributor Author

lmb commented Mar 8, 2023

/ci-datapath

@lmb
Copy link
Contributor Author

lmb commented Mar 8, 2023

Actually working now: https://github.com/cilium/cilium/actions/runs/4363798670

@lmb lmb force-pushed the lmb/egw-tests-ci-datapath-update branch from d1240bb to a26eeda Compare March 8, 2023 12:05
@lmb lmb requested a review from brb March 8, 2023 12:05
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@brb brb added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 8, 2023
@brb brb merged commit 5d8335d into master Mar 9, 2023
@brb brb deleted the lmb/egw-tests-ci-datapath-update branch March 9, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants