Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hive: fix documentation for cell.Provide & cell.ProvidePrivate #24238

Merged
merged 1 commit into from Mar 9, 2023
Merged

hive: fix documentation for cell.Provide & cell.ProvidePrivate #24238

merged 1 commit into from Mar 9, 2023

Conversation

mhofstetter
Copy link
Member

No description provided.

@mhofstetter
hive: fix documentation for cell.Provide & cell.ProvidePrivate
6c11749 
Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter requested a review from a team as a code owner March 8, 2023 09:28
@mhofstetter mhofstetter requested a review from thorn3r March 8, 2023 09:28
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 8, 2023
@mhofstetter mhofstetter added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 8, 2023
bimmlerd
bimmlerd approved these changes Mar 8, 2023
View reviewed changes
Copy link
Member

@bimmlerd bimmlerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

historical baggage, lgtm

@mhofstetter
Copy link
Member Author

/test

@mhofstetter mhofstetter added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 8, 2023
@tklauser tklauser merged commit 9bb6e50 into cilium:master Mar 9, 2023
@mhofstetter mhofstetter deleted the pr/mhofstetter/hive-provide-docs branch March 9, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bimmlerd bimmlerd bimmlerd approved these changes

@thorn3r thorn3r Awaiting requested review from thorn3r thorn3r was automatically assigned from cilium/sig-agent

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mhofstetter @bimmlerd @tklauser