Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparatory refactoring for IPAM pools #24247

Merged
merged 4 commits into from Mar 14, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Mar 8, 2023

This PR contains refactoring and cleanup commits to support IPAM pools. The changes were split out of #22762 to ease review. See individual commits for details.

No functional changes except for the first commit 4947c1a.

Joint work with @gandro.

This is needed to parse entries like:

    cluster-pool-map: \
        "mars=ipv4-cidrs:172.16.0.0/16,172.17.0.0/16;ipv4-mask-size:24
         jupiter=ipv4-cidrs:192.168.0.0/19;ipv4-mask-size:26"

which will be used for IPAM pools in cilium-operator.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM labels Mar 8, 2023
@tklauser tklauser requested review from a team as code owners March 8, 2023 15:27
gandro and others added 3 commits March 8, 2023 16:39
This commit contains no functional changes.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
This function is only used once inside the package, so inline it

Signed-off-by: Tobias Klauser <tobias@cilium.io>
It will be used by the IPAM pools allocator in a subsequent
commit. This commit contains no functional changes.

Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/ipam-refactoring-for-ipam-pools branch from f4bae37 to 1cc6e85 Compare March 8, 2023 15:40
@tklauser
Copy link
Member Author

tklauser commented Mar 8, 2023

/test

@christarazi christarazi added the kind/enhancement This would improve or streamline existing functionality. label Mar 8, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 14, 2023
@tklauser tklauser merged commit a152bfe into master Mar 14, 2023
@tklauser tklauser deleted the pr/ipam-refactoring-for-ipam-pools branch March 14, 2023 09:13
@gandro gandro mentioned this pull request May 16, 2023
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants