Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodemanager: inject ipcache into nodemanager via hive #24261

Merged

Conversation

mhofstetter
Copy link
Member

Injecting the IPCache into the nodemanager via hive instead of setting it explicitly from within the daemon.

This is possible since the IPCache itself is now provided via cell. #24073

@mhofstetter mhofstetter requested a review from a team as a code owner March 9, 2023 11:15
@mhofstetter mhofstetter requested a review from thorn3r March 9, 2023 11:15
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 9, 2023
@mhofstetter mhofstetter added release-note/misc This PR makes changes that have no direct user impact. and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 9, 2023
@mhofstetter
Copy link
Member Author

/test

Injecting the IPCache into the nodemanager via hive instead of setting
it explicitly from within the daemon.

Signed-off-by: Marco Hofstetter <marco.hofstetter@isovalent.com>
@mhofstetter mhofstetter force-pushed the pr/mhofstetter/nodemanager-inject-ipcache branch from 527700a to 63683f9 Compare March 13, 2023 07:55
@mhofstetter
Copy link
Member Author

rebased to master and resolved conflicts

@mhofstetter
Copy link
Member Author

/test

Copy link
Contributor

@thorn3r thorn3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 14, 2023
@borkmann borkmann merged commit b20ab61 into cilium:master Mar 14, 2023
@mhofstetter mhofstetter deleted the pr/mhofstetter/nodemanager-inject-ipcache branch March 15, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants