Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add IPAM modes comparison table #24285

Merged
merged 1 commit into from Mar 13, 2023
Merged

Add IPAM modes comparison table #24285

merged 1 commit into from Mar 13, 2023

Conversation

raphink
Copy link
Member

@raphink raphink commented Mar 10, 2023 •
edited by qmonnet

Signed-off-by: Raphaël Pinson raphael@isovalent.com

docs: Add a comparison table for IPAM modes

@raphink
Add IPAM modes comparison table
1962c46 
Signed-off-by: Raphaël Pinson <raphael@isovalent.com>
@raphink raphink requested review from a team as code owners March 10, 2023 09:03
@raphink raphink requested review from gandro and qmonnet March 10, 2023 09:03
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 10, 2023
@qmonnet qmonnet added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM labels Mar 10, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 10, 2023
qmonnet
qmonnet approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Too bad we have to scroll quite a lot horizontally to display the full table, but I don't have a better suggestion. We could have the table displayed “vertically” instead (feature names at the top), but then the feature names would be hard to read if we made the columns narrow enough for it to fit.

@raphink
Copy link
Member Author

raphink commented Mar 10, 2023

@qmonnet we have too many IPAM options? 😁

gandro
gandro approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@qmonnet
Copy link
Member

qmonnet commented Mar 13, 2023

Documentation change only, no need for the full CI suite.

@qmonnet qmonnet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 13, 2023
@jrajahalme jrajahalme merged commit b3b10aa into cilium:master Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/ipam IP address management, including cloud IPAM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@raphink @qmonnet @gandro @jrajahalme