versioncheck: fix parsing of snapshot release versions #24286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than enumerating the test cases and having to look up the exact version and constraint, let's report this information as part of the test failure. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added
the
release-note/misc
For the Cilium v1.14 release cycle we started doing snapshot releases which are tagged in the format vX.Y.Z-snapshotN. Let versioncheck.Version accept this version format. For cilium/cilium-cli#1448 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/versioncheck-allow-snapshot
branch
from
40e11ec
to
d7f973b
Compare
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Mar 14, 2023
…k fix cilium-cli uses the github.com/cilium/cilium/pkg/versioncheck package to parse Cilium versions. In the latest version, this package was fixed to allow parsing snapshot release versions, cf. cilium/cilium#24286 For #1448 Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
added a commit
to cilium/cilium-cli
that referenced
this pull request
Mar 15, 2023
…k fix cilium-cli uses the github.com/cilium/cilium/pkg/versioncheck package to parse Cilium versions. In the latest version, this package was fixed to allow parsing snapshot release versions, cf. cilium/cilium#24286 For #1448 Signed-off-by: Tobias Klauser <tobias@cilium.io>
michi-covalent
pushed a commit
to michi-covalent/cilium
that referenced
this pull request
May 30, 2023
…k fix cilium-cli uses the github.com/cilium/cilium/pkg/versioncheck package to parse Cilium versions. In the latest version, this package was fixed to allow parsing snapshot release versions, cf. cilium#24286 For cilium#1448 Signed-off-by: Tobias Klauser <tobias@cilium.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the Cilium v1.14 release cycle we started doing snapshot releases which are tagged in the format vX.Y.Z-snapshotN. Let
versioncheck.Versionaccept this version format.For cilium/cilium-cli#1448
First commit cleans up the test failure reporting in the versioncheck package. Second commit fixes parsing of the version.