Add new logging format option, 'json-ts', for JSON formatted logs with timestamps #24307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
learnitall
force-pushed
the
pr/learnitall/add-json-ts-format
branch
3 times, most recently
from
7dd3294
to
179a43a
Compare
learnitall
force-pushed
the
pr/learnitall/add-json-ts-format
branch
2 times, most recently
from
c68cde5
to
482c14a
Compare
|
Looks like pushing the images failed due to a bad gateway error from quay: I'm going to rebase to re-trigger the tests. |
learnitall
force-pushed
the
pr/learnitall/add-json-ts-format
branch
from
482c14a
to
bf35cc4
Compare
rolinh
approved these changes
Mar 29, 2023
rolinh
added
area/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
learnitall
force-pushed
the
pr/learnitall/add-json-ts-format
branch
from
bf35cc4
to
06d46fe
Compare
This commit adds a new log formatter named 'json-ts', which can be used to enable json logs that include timestamps. Normally, timestamps for logs can be collected through the use of k8s container logging system, ie by passing `--timestamps` to `kubectl logs`. Relying on k8s for log timestamps is not always available however, therefore it is useful to have the ability to add timestamps if needed in special cases. One case in which this is useful is for programmatically parsing through the `cilium-cni` log file, in order to observe and record CNI events. Signed-off-by: Ryan Drew <ryan.drew@isovalent.com>
learnitall
force-pushed
the
pr/learnitall/add-json-ts-format
branch
from
06d46fe
to
5ba11e0
Compare
|
Hey @cilium/cli just want to double-check and see if there is anything you need from me to get this merged? |
michi-covalent
approved these changes
Apr 3, 2023
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new log formatter named 'json-ts', which can be used to enable json logs that include timestamps. Normally, timestamps for logs can be collected through the use of k8s container logging system, ie by passing
--timestampstokubectl logs. Relying on k8s for log timestamps is not always available however, therefore it is useful to have the ability to add timestamps if needed in special cases.One case in which this is useful is for programmatically parsing through the
cilium-cnilog file, in order to observe and record CNI events.Correct me if I'm wrong, but I'm pretty sure this needs the following labels:
release-note/miscarea/miscPlease ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXXline if the commit addresses a particularGitHub issue.