Fix broken target_url for conformance-clustermesh #24315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing check_url env var to conformance-clustermesh workflow. Otherwise, "Details" link won't appear on the check result. Signed-off-by: Yutaro Hayakawa <yutaro.hayakawa@isovalent.com>
YutaroHayakawa
added
kind/bug/CI
YutaroHayakawa
requested review from
brlbil,
christarazi and
giorio94
and removed request for
brlbil and
christarazi
christarazi
approved these changes
Mar 13, 2023
YutaroHayakawa
force-pushed
the
yutaro/clustermesh-tests-missing-check-url
branch
from
c61b27a
to
a1596ed
Compare
|
I reverted the temp commit for preview. It looked like this.
While this commit only contains the cosmetic change in GHA, I think it's safe to make this ready-to-merge without an e2e test. |
YutaroHayakawa
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing check_url (which later used as a
target_urlin various places) env variable. If it is missing, "Details" link next to the test result indicator won't appear like this.