gateway-api: Fix flaky conformance tests #24317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to update test fixture for HTTRRoute header matching from the upstream. The main point is to split header matching condition to diff sets (i.e. OR condition). Signed-off-by: Tam Mach <tam.mach@cilium.io>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
sayboras
force-pushed
the
tam/gw-flaky-test
branch
3 times, most recently
from
cd7923a
to
a497fc1
Compare
This commit is to make sure that header matching rules are sorted in a deterministic way, so that the behavior is predictable in envoy. The main changes are as per below: - Process http routes based on order from spec instead of random order from map. - Use sort.Stable to reverse the original order of equal elements. - Make sure that less(i, j) and less(j, i) return false if i-th and j-th elements are equal. Kindly note that envoy will just iteratively check rule one by one, if a match is found, subsequent rule will not be considered. Fixes: cilium#23999 Signed-off-by: Tam Mach <tam.mach@cilium.io>
This commit is to make sure that the virtual hosts are created in the same order of appearance of HTTP Route spec. The changes are to split nested map into two separate maps, and handle uniqueness. Fixes: cilium#24217 Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
…n test Signed-off-by: Tam Mach <tam.mach@cilium.io>
…n test Signed-off-by: Tam Mach <tam.mach@cilium.io>
Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/gw-flaky-test
branch
from
a497fc1
to
56e09a7
Compare
…test Signed-off-by: Tam Mach <tam.mach@cilium.io>
Also, taking this chance to replace depecrated Append attribute with AppendAction. Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is to match with names used in upstream Conformance. The benefit is to have faster lookup: - If a particular test is failed - If a particular test is missing Signed-off-by: Tam Mach <tam.mach@cilium.io>
This was overlooked in previous commits. Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is a new tests introduced as part of v0.6.0. Signed-off-by: Tam Mach <tam.mach@cilium.io>
This is a new tests introduced as part of v0.6.0. Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/gw-flaky-test
branch
from
f1e2acc
to
e01d37e
Compare
This is a new tests introduced as part of v0.6.0. GHA action setting for this test is enabled. Signed-off-by: Tam Mach <tam.mach@cilium.io>
sayboras
force-pushed
the
tam/gw-flaky-test
branch
from
e01d37e
to
201fc94
Compare
|
Full CI is not required, as the code changes are related to Gateway API/Ingress/Unit tests, which are verified as part of GHA. |
nbusseneau
approved these changes
Mar 14, 2023
|
/test Job 'Cilium-PR-K8s-1.16-kernel-4.19' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
/test-1.16-4.19 Job 'Cilium-PR-K8s-1.16-kernel-4.19' failed: Click to show.Test NameFailure OutputIf it is a flake and a GitHub issue doesn't already exist to track it, comment |
|
/mlh new-flake Cilium-PR-K8s-1.16-kernel-4.19 👍 created #24379 |
|
Above failure is fixed in #24336, which is just merged. Re-run is not required. |
sayboras
added
the
ready-to-merge
sayboras
added
the
needs-backport/1.13
sayboras
added
backport-pending/1.13
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The goal is to have unit tests for Conformance test cases for faster feedback and stability. As part of this PR, two flaky tests are fixed 🤞.
Testing
Testing was done in https://github.com/cilium/cilium/actions/runs/4402111837, which are having 20+ consecutive successful runs.