Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: nodeport: don't track L2 addr for connection to local backend #24324

Merged
merged 1 commit into from Mar 13, 2023

Conversation

julianwiedmann
Copy link
Member

Replies by a local backend either get their L2 resolution by the stack, or (when bpf_lxc uses bpf-host-routing) by bpf_redirect_neigh(). But fib_redirect_*() will never fall through to the L2 neigh cache to get the client's MAC address.

Replies by a local backend either get their L2 resolution by the stack, or
(when bpf_lxc uses bpf-host-routing) by bpf_redirect_neigh(). But
fib_redirect_*() will never fall through to the L2 neigh cache to get
the client's MAC address.

Signed-off-by: Julian Wiedmann <jwi@isovalent.com>
@julianwiedmann julianwiedmann added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Mar 13, 2023
@julianwiedmann julianwiedmann requested a review from a team as a code owner March 13, 2023 06:57
@julianwiedmann
Copy link
Member Author

/test

Copy link
Member

@borkmann borkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@julianwiedmann
Copy link
Member Author

Filed #24342 for the test-runtime flake, re-running.

@julianwiedmann
Copy link
Member Author

/test-runtime

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 13, 2023
@borkmann borkmann merged commit 3d96cb5 into cilium:master Mar 13, 2023
@julianwiedmann julianwiedmann deleted the 1.14-bpf-nodeport-l2-addr branch March 13, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants