Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf, ipcache: unconditionally assume LPM trie delete/dump support #24377

Merged
merged 1 commit into from Mar 15, 2023

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Mar 15, 2023

Delete [1] and dump [2] operations on LPM trie maps are supported since Linux kernel version 4.16. For Cilium v1.14, the minimum required kernel version is 4.19.57 [3]. Thus we can now unconditionally assume support for delete and dump operations on the ipcache map.

[1] torvalds/linux@e454cf5
[2] torvalds/linux@b471f2f
[3] https://docs.cilium.io/en/latest/operations/system_requirements/#base-requirements

For #22116

@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Mar 15, 2023
Delete [1] and dump [2] operations on LPM trie maps are supported since
Linux kernel version 4.16. For Cilium v1.14, the minimum required kernel
version is 4.19.57 [3].  Thus we can now unconditionally assume support
for delete and dump operations on the ipcache map.

[1] torvalds/linux@e454cf5
[2] torvalds/linux@b471f2f
[3] https://docs.cilium.io/en/latest/operations/system_requirements/#base-requirements

For #22116

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser force-pushed the pr/tklauser/ipcache-lpm-trie-delete branch from dc0831c to 9108e0d Compare March 15, 2023 03:50
@tklauser
Copy link
Member Author

/test

@tklauser tklauser marked this pull request as ready for review March 15, 2023 04:01
@tklauser tklauser requested review from a team as code owners March 15, 2023 04:01
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean-up!

@tklauser tklauser merged commit 84901e4 into master Mar 15, 2023
@tklauser tklauser deleted the pr/tklauser/ipcache-lpm-trie-delete branch March 15, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants