bpf, datapath: unconditionally assume support for LRU hash maps #24378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
kind/cleanup
tklauser
force-pushed
the
pr/tklauser/bpf-assume-lru-hash-maps
branch
4 times, most recently
from
c665d12
to
02668ec
Compare
LRU hash maps are available since kernel version 4.10 [1], [2], [3]. For Cilium v1.14, the minimum required kernel version is 4.19.57 [4]. Thus we can now unconditionally assume support for that map type. [1] https://github.com/iovisor/bcc/blob/master/docs/kernel-versions.md#map-types [2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=29ba732acbeece1e34c68483d1ec1f3720fa1bb3 [3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3a08c2fd763450a927d1130de078d6f9e74944fb [4] https://docs.cilium.io/en/latest/operations/system_requirements/#base-requirements For #22116 Signed-off-by: Tobias Klauser <tobias@cilium.io>
As of the previous commit we unconditionally assume support for LRU hash BPF maps. Thus the map type dependent GC interval calculation for the ctmap can be simplified to always assume LRU hash maps. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/bpf-assume-lru-hash-maps
branch
from
02668ec
to
38c1033
Compare
|
/test |
jrajahalme
approved these changes
Mar 15, 2023
|
/test-runtime hit #23272 https://jenkins.cilium.io/job/Cilium-PR-Runtime-net-next/5546/ |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LRU hash maps are available since kernel version 4.10 [1], [2], [3]. For Cilium v1.14, the minimum required kernel version is 4.19.57 [4]. Thus we can now unconditionally assume support for that map type.
[1] https://github.com/iovisor/bcc/blob/master/docs/kernel-versions.md#map-types
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=29ba732acbeece1e34c68483d1ec1f3720fa1bb3
[3] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3a08c2fd763450a927d1130de078d6f9e74944fb
[4] https://docs.cilium.io/en/latest/operations/system_requirements/#base-requirements
For #22116