Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Cilium CLI L7 tests #24414

Merged
merged 3 commits into from Mar 22, 2023
Merged

Run Cilium CLI L7 tests #24414

merged 3 commits into from Mar 22, 2023

Conversation

meyskens
Copy link
Member

@meyskens meyskens commented Mar 16, 2023 •
edited

Part of #23784 to remove the L7 TLS test to cilium-cli. The test case got merged in cilium/cilium-cli#1406 but does not yet run inside the CI. This PR removed the old test and sets up the CI to be able to run the test. The test will run once it reaches a release of the CLI tool

fixes #22404

Migrate L7 TLS Ginkgo tests to cilium-cli

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 16, 2023
@meyskens meyskens added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Mar 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Mar 16, 2023
@meyskens meyskens added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. area/servicemesh GH issues or PRs regarding servicemesh labels Mar 16, 2023
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Mar 16, 2023
@meyskens meyskens marked this pull request as ready for review March 20, 2023 13:08
@meyskens meyskens requested review from a team as code owners March 20, 2023 13:08
@meyskens
Copy link
Member Author

/test

@meyskens meyskens mentioned this pull request Mar 20, 2023
Closed
9 tasks
@joestringer
Copy link
Member

Heads up that you'll need to read the ### FOR TESTING PURPOSES note at the top of the workflows and follow those steps in order to test the new functionality. It's likely that the current CI runs for the GitHub workflows are not testing the changes in this PR.

@meyskens
Copy link
Member Author 

[=] Test [client-egress-l7-tls-deny-without-headers]
..
[=] Test [client-egress-l7-tls-headers]
..

Tests run now, even on cloud providers in #24489

nbusseneau
nbusseneau approved these changes Mar 21, 2023
View reviewed changes
Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meyskens
Remove the L7 TLS proxy test from Ginkgo
3210d29 
This test has been moved to cilium-cli and is no longer needed in Ginkgo

Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
@meyskens
Enable L7 loadbalancing in conformance tests
f1578c0 
This enables envoy and k8s secret selection in conectivity tests.
This allows for the L7 connectivity tests to run L7 policy tests.

Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
@meyskens
Use Cilium CLI v0.13.2 to include the L7 TLS test
bcb3e4c 
Signed-off-by: Maartje Eyskens <maartje.eyskens@isovalent.com>
@meyskens
Copy link
Member Author

/test

@meyskens
Copy link
Member Author

re-triggered jenkins after rebase

@meyskens meyskens added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 22, 2023
@borkmann borkmann merged commit 087cf01 into cilium:master Mar 22, 2023
42 checks passed
@meyskens meyskens deleted the meyskens/rm-ginkgo-l7-tls branch March 27, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nebril nebril nebril approved these changes

@nbusseneau nbusseneau nbusseneau approved these changes

@jrajahalme jrajahalme Awaiting requested review from jrajahalme

Assignees
No one assigned
Labels
area/CI Continuous Integration testing issue or flake area/servicemesh GH issues or PRs regarding servicemesh ci/hyperjump ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI: K8sAgentPolicyTest Basic Test TLS policy
5 participants
@meyskens @joestringer @nebril @nbusseneau @borkmann