Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add section on development and RC images #24424

Merged
merged 1 commit into from Mar 22, 2023
Merged

Conversation

borkmann
Copy link
Member

@borkmann borkmann commented Mar 17, 2023

@borkmann borkmann added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Mar 17, 2023
@borkmann borkmann requested a review from a team as a code owner March 17, 2023 09:49
@borkmann borkmann requested a review from qmonnet March 17, 2023 09:49
@borkmann
Copy link
Member Author

(no CI trigger needed)

@borkmann borkmann force-pushed the pr/readme-dev branch 2 times, most recently from b9d2a40 to 92b1b6d Compare March 17, 2023 09:54
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

This table needs to be updated each time a snapshot or RC is released, right? So we probably need a follow-up PR for the checklist in https://github.com/cilium/release?

@borkmann
Copy link
Member Author

This table needs to be updated each time a snapshot or RC is released, right? So we probably need a follow-up PR for the checklist in https://github.com/cilium/release?

Ah yes, this would be nice to add to the checklist. Imo, it would make snapshots/rcs more visible for testing.

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree we can add another step to the release process... for what it's worth, this table will be a bit painful to update during the release just because it's hard to script up, but I guess we can work on improving that scripting, eg by templating this file. Alternatively it's a bit easier if it's in sphinx/docs because we can just put this table in its own file and rewrite the whole file each time we do a release.

Please also send a PR to github.com/cilium/release for the update to the process.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved
It's useful to point the community to some of the daily builds for ease of
testing master or early snapshots for upcoming releases. Add a new section.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Mar 22, 2023
@borkmann borkmann merged commit 44756ba into master Mar 22, 2023
41 checks passed
@borkmann borkmann deleted the pr/readme-dev branch March 22, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants